[MINOR] Code refactor on hash join utils #6999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We are currently in the process of refactoring the join codebase to make it more amenable to adding new kinds of joins while maintaining code reuse. This involves moving some functions in between files to accommodate such new join executors. In this context, this PR makes some structural improvements to the codebase without introducing any substantial new functionality. As part of this reorganization, we are introducing an enumeration to control the required input distribution for
SymmetricHashJoinExec
.What changes are included in this PR?
Refactoring the join codebase, focusing on making changes to the utilities and conducting some refactoring on the
SymmetricHashJoinExec
code.To reduce ambiguity between the indices calculations between HashJoinExec and SHJ,
get_anti_indices
->get_pruning_anti_indices
get_semi_indices
->get_pruning_semi_indices
Also, we moved some functionality into functions named
build_filter_expression_graph
Are these changes tested?
With existing tests.
Are there any user-facing changes?
No