Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass schema_infer_max_records to JsonFormat. #6945

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Pass schema_infer_max_records to JsonFormat. #6945

merged 4 commits into from
Jul 13, 2023

Conversation

vincev
Copy link
Contributor

@vincev vincev commented Jul 13, 2023 •
edited
Loading

Which issue does this PR close?

Closes #6944.

Rationale for this change

Propagate override ndjson_schema_infer_max_records to JsonFormat.

What changes are included in this PR?

Pass ndjson_schema_infer_max_records override to JsonFormat.

Are these changes tested?

Yes added test to check the override.

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Jul 13, 2023
alamb
alamb approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincev -- looks good to me

@alamb alamb merged commit 3de209e into apache:main Jul 13, 2023
@vincev vincev deleted the json branch July 13, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow override of schema_infer_max_records for NdJsonReadOptions
2 participants
@vincev @alamb