Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump sqllogictest to 0.15.0 #6941

Merged
merged 1 commit into from
Jul 13, 2023
Merged

deps: bump sqllogictest to 0.15.0 #6941

merged 1 commit into from
Jul 13, 2023

Conversation

jonahgao
Copy link
Member

@jonahgao jonahgao commented Jul 13, 2023 •
edited
Loading

Which issue does this PR close?

Closes #6930 .

Rationale for this change

Adapt to the changelog of sqllogictest:

Allow multiple connections to the database in a single test case, which is useful for testing the transaction behavior. This can be achieved by attaching a connection foo record before the query or statement.
(parser) Add Record::Connection.
(runner) Breaking change: Since the runner may establish multiple connections at runtime, Runner::new now takes a impl MakeConnection, which is usually a closure that returns a try-future of the AsyncDB instance.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jul 13, 2023
alamb
alamb approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you for doing this @jonahgao 🙏

@alamb alamb merged commit f245869 into apache:main Jul 13, 2023
@jonahgao jonahgao deleted the upgrade_sqllogictest branch July 14, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahgao @alamb