Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add FixedSizeBinaryTest #6895

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Minor: Add FixedSizeBinaryTest #6895

merged 4 commits into from
Jul 14, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 9, 2023

Which issue does this PR close?

Related to #6891

Rationale for this change

#6891 needs some tests, but since there is no fixed size binary examples yet in .slt files I figured I would add some rather than asking @maxburke to do it

What changes are included in this PR?

Add basic test coverage for FixedSizeBinary

Are these changes tested?

Only tests

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jul 9, 2023
@alamb alamb force-pushed the alamb/fixed_size_binary_test branch from bf2067d to b229db0 Compare July 9, 2023 14:42
alamb
alamb commented Jul 9, 2023
View reviewed changes
datafusion/core/tests/sqllogictests/test_files/binary.slt Outdated

# Comparison
# https://github.com/apache/arrow-datafusion/pull/6891
query error DataFusion error: Internal error: Data type FixedSizeBinary\(3, "0,1,2"\) not supported for scalar operation 'eq' on dyn array\. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work after #6891

@alamb alamb mentioned this pull request Jul 9, 2023
Merged
@alamb alamb force-pushed the alamb/fixed_size_binary_test branch from b229db0 to 64e26ed Compare July 9, 2023 22:52
@alamb
Copy link
Contributor Author

alamb commented Jul 9, 2023

@maxburke sadly it seems like your change in #6891 isn't sufficient -- the tests in this PR now fail with

query error DataFusion error: Arrow error: Compute error: eq_dyn_binary_scalar only supports Binary or LargeBinary arrays

When I try to compare them

@maxburke
Copy link
Contributor

maxburke commented Jul 9, 2023

@maxburke sadly it seems like your change in #6891 isn't sufficient -- the tests in this PR now fail with

query error DataFusion error: Arrow error: Compute error: eq_dyn_binary_scalar only supports Binary or LargeBinary arrays

When I try to compare them

Possibly needs this change that was just merged into Arrow? apache/arrow-rs#4492

@alamb
Copy link
Contributor Author

alamb commented Jul 9, 2023 •
edited
Loading

Possibly needs this change that was just merged into Arrow? apache/arrow-rs#4492

I am pretty sure I did get your (previously the error message was different -- you can see the error change 7fb0d3f)

Update: Yes, you are right that should land in DataFusion sometime next week. I'll add a note to the test. Thank you

@alamb
Copy link
Contributor Author

alamb commented Jul 14, 2023

I an merging these tests in so we have coverage of the FixedSizeBinary workload and have a place to extend them going forward

@alamb alamb merged commit d316702 into apache:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @maxburke