MINOR: Fix ordering of the aggregate_source_with_order table #6852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
mustafasrepo
commented
Jul 5, 2023
| @@ -0,0 +1,101 @@ | |||
| c1,c2,c3,c4,c5,c6,c7,c8,c9,c10,c11,c12,c13 | |||
There was a problem hiding this comment.
This file is same with aggregate_test_100.csv file. However, rows are reordered according to c1 ASC
alamb
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Thanks @mustafasrepo -- I left a naming suggestion I think will improve this PR but I don't think it is required
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Jul 6, 2023
…6852) * Fix ordering of the source * rename file path more decriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6850.
Rationale for this change
See for #6850 explanation
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?