Minor: Add one more assert to hash_array_primitive
#6834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 3, 2023
| @@ -96,6 +96,12 @@ fn hash_array_primitive<T>( | |||
| T: ArrowPrimitiveType, | |||
| <T as arrow_array::ArrowPrimitiveType>::Native: HashValue, | |||
| { | |||
| assert_eq!( | |||
There was a problem hiding this comment.
this is the same assert copied from a few lines down and makes me feel better about
let value = unsafe { array.value_unchecked(i) };
Dandandan
approved these changes
Jul 3, 2023
2010YOUY01
pushed a commit
to 2010YOUY01/arrow-datafusion
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #6816 from @Dandandan
Rationale for this change
There are some
unsafeblocks in this function, so I would like to make it more obvious that they are okWhat changes are included in this PR?
Add the same assert to
hash_array_primitiveas are inhash_arrayAre these changes tested?
existing tests
Are there any user-facing changes?