Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Log TPCH benchmark results #6813

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 30, 2023

Which issue does this PR close?

N/A

Rationale for this change

I wanted to validate y POC grouping code that it got the right answer when running benchmarks

What changes are included in this PR?

the tpch benchmark driver now shows the output if RUST_LOG is enabled

Before this PR

cargo run --profile dev --bin tpch -- benchmark datafusion --iterations 5 --format parquet -q 17 --path <data> 
...

Running benchmarks with the following options: DataFusionBenchmarkOpt { query: Some(17), debug: false, iterations: 5, partitions: 2, batch_size: 8192, path: "/Users/alamb/Software/arrow-datafusion/benchmarks/data/", file_format: "parquet", mem_table: false, output_path: None, disable_statistics: false }
Query 17 iteration 0 took 6383.7 ms and returned 1 rows
Query 17 iteration 1 took 6341.2 ms and returned 1 rows
Query 17 iteration 2 took 6337.4 ms and returned 1 rows
Query 17 iteration 3 took 6202.9 ms and returned 1 rows
Query 17 iteration 4 took 6222.3 ms and returned 1 rows
Query 17 avg time: 6297.51 ms

After this PR:

 cargo run --profile dev --bin tpch -- benchmark datafusion --iterations 5 --format parquet -q 17 --path <data> 
...
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: Some(17), debug: false, iterations: 5, partitions: 2, batch_size: 8192, path: "/Users/alamb/Software/arrow-datafusion/benchmarks/data/", file_format: "parquet", mem_table: false, output_path: None, disable_statistics: false }
[2023-06-30T15:33:26Z INFO  tpch] output:

    +-------------------+
    | avg_yearly        |
    +-------------------+
    | 348406.0542857143 |
    +-------------------+


Query 17 iteration 0 took 6401.7 ms and returned 1 rows
[2023-06-30T15:33:33Z INFO  tpch] output:

    +-------------------+
    | avg_yearly        |
    +-------------------+
    | 348406.0542857143 |
    +-------------------+


Query 17 iteration 1 took 6348.3 ms and returned 1 rows
...

Are these changes tested?

No -- they are a debugging tool

Are there any user-facing changes?

No -- internal debugging tool

@alamb alamb added the development-process Related to development process of DataFusion label Jun 30, 2023
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label Jun 30, 2023
@alamb alamb marked this pull request as ready for review June 30, 2023 17:21
@Dandandan Dandandan merged commit ea71acf into apache:main Jul 1, 2023
2010YOUY01 pushed a commit to 2010YOUY01/arrow-datafusion that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants