Use checked division kernel #6792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
alamb
approved these changes
Jun 29, 2023
|
|
||
| assert_eq!(simplify(expr), expected); | ||
| assert!( |
There was a problem hiding this comment.
This is consistent with postgres 👍
postgres=# select 0 / 0;
ERROR: division by zero
|
cc @viirya |
|
Hmm, it is inconsistent. We should fix it. But we will prefer default behavior is to get null instead of query error. That is story of Spark but I agree DataFusion doesn't necessarily to follow it at all.
Is it an issue? In Spark, Divide expression output is nullable always. I think producing null from non-nullable input columns is totally fine if it follows the expression's output type definition. So the issue is more about inconsistency. Looks okay to me. |
2010YOUY01
pushed a commit
to 2010YOUY01/arrow-datafusion
that referenced
this pull request
Jul 5, 2023
This was referenced Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6791
Rationale for this change
The current behaviour is inconsistent, can lead to nulls in non-nullable columns, and is pretty surprising.
A future iteration of the upstream arithmetic kernels is also likely to make this the only option - apache/arrow-rs#2647 (comment)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?