Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add array / array sqllogic tests for array_contains #6771

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Minor: Add array / array sqllogic tests for array_contains #6771

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd40420
Minor: Add array / array sqllogic tests
alamb Jun 26, 2023
64f50cd
Merge remote-tracking branch 'apache/main' into alamb/array_contains_…
alamb Jun 28, 2023
eb6e88f
Add additional nested cases
alamb Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 109 additions & 0 deletions datafusion/core/tests/sqllogictests/test_files/array.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
## Array expressions Tests
#############

## make_array

# array scalar function #1
query ??? rowsort
select make_array(1, 2, 3), make_array(1.0, 2.0, 3.0), make_array('h', 'e', 'l', 'l', 'o');
Expand Down Expand Up @@ -61,6 +63,8 @@ select make_array(make_array()), make_array(make_array(make_array()))
----
[[]] [[[]]]

## array_append

# TODO issue: https://github.com/apache/arrow-datafusion/issues/6596
# array_append scalar function #1
query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\)
Expand All @@ -80,6 +84,8 @@ select array_append(make_array(1, 2, 3), 4), array_append(make_array(1.0, 2.0, 3
----
[1, 2, 3, 4] [1.0, 2.0, 3.0, 4.0] [h, e, l, l, o]

## array_prepend

# array_prepend scalar function #1
query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\)
caused by
Expand All @@ -98,6 +104,8 @@ select array_prepend(1, make_array(2, 3, 4)), array_prepend(1.0, make_array(2.0,
----
[1, 2, 3, 4] [1.0, 2.0, 3.0, 4.0] [h, e, l, l, o]

## array_fill

# array_fill scalar function #1
query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\)
caused by
Expand All @@ -116,6 +124,8 @@ caused by
Internal error: Optimizer rule 'simplify_expressions' failed, due to generate a different schema, original schema: DFSchema \{ fields: \[DFField \{ qualifier: None, field: Field \{ name: "array_fill\(Int64\(1\),make_array\(\)\)", data_type: List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \} \}\], metadata: \{\} \}, new schema: DFSchema \{ fields: \[DFField \{ qualifier: None, field: Field \{ name: "array_fill\(Int64\(1\),make_array\(\)\)", data_type: List\(Field \{ name: "item", data_type: Null, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: \{\} \} \}\], metadata: \{\} \}\. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
select array_fill(1, make_array())

## array_concat

# array_concat scalar function #1
query ?? rowsort
select array_concat(make_array(1, 2, 3), make_array(4, 5, 6), make_array(7, 8, 9)), array_concat(make_array([1], [2]), make_array([3], [4]));
Expand Down Expand Up @@ -152,6 +162,8 @@ caused by
Error during planning: Cannot automatically convert List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\) to List\(Field \{ name: "item", data_type: Null, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\)
select array_concat(make_array(), make_array(2, 3));

## array_position

# array_position scalar function #1
query III
select array_position(['h', 'e', 'l', 'l', 'o'], 'l'), array_position([1, 2, 3, 4, 5], 5), array_position([1, 1, 1], 1);
Expand All @@ -170,12 +182,16 @@ caused by
Error during planning: Cannot automatically convert List\(Field \{ name: "item", data_type: UInt8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\) to UInt8
select array_positions(['h', 'e', 'l', 'l', 'o'], 'l'), array_positions([1, 2, 3, 4, 5], 5), array_positions([1, 1, 1], 1);

## array_replace

# array_replace scalar function
query ???
select array_replace(make_array(1, 2, 3, 4), 2, 3), array_replace(make_array(1, 4, 4, 5, 4, 6, 7), 4, 0), array_replace(make_array(1, 2, 3), 4, 0);
----
[1, 3, 3, 4] [1, 0, 0, 5, 0, 6, 7] [1, 2, 3]

## array_to_string

# array_to_string scalar function
query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\)
caused by
Expand All @@ -194,6 +210,8 @@ caused by
Error during planning: Cannot automatically convert Utf8 to List\(Field \{ name: "item", data_type: Null, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\)
select array_to_string(make_array(), ',')

## cardinality

# cardinality scalar function
query III
select cardinality(make_array(1, 2, 3, 4, 5)), cardinality([1, 3, 5]), cardinality(make_array('h', 'e', 'l', 'l', 'o'));
Expand All @@ -212,6 +230,8 @@ select cardinality(make_array()), cardinality(make_array(make_array()))
----
0 0

## trim_array

# trim_array scalar function #1
query ???
select trim_array(make_array(1, 2, 3, 4, 5), 2), trim_array(['h', 'e', 'l', 'l', 'o'], 3), trim_array([1.0, 2.0, 3.0], 2);
Expand All @@ -236,6 +256,8 @@ select trim_array(make_array(), 0), trim_array(make_array(), 1)
----
[] []

## array_length

# array_length scalar function
query III rowsort
select array_length(make_array(1, 2, 3, 4, 5)), array_length(make_array(1, 2, 3)), array_length(make_array([1, 2], [3, 4], [5, 6]));
Expand Down Expand Up @@ -266,6 +288,8 @@ select array_length(make_array()), array_length(make_array(), 1), array_length(m
----
0 0 NULL

## array_dims

# array_dims scalar function
query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\)
caused by
Expand All @@ -290,6 +314,8 @@ select array_ndims(make_array(1, 2, 3)), array_ndims(make_array([1, 2], [3, 4]))
----
1 2 5

## array_ndims

# array_ndims scalar function #2
query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\)
caused by
Expand All @@ -302,6 +328,8 @@ select array_ndims(make_array()), array_ndims(make_array(make_array()))
----
1 2

## array concatenate opeartor

# array concatenate operator #1 (like array_concat scalar function)
query ?? rowsort
select make_array(1, 2, 3) || make_array(4, 5, 6) || make_array(7, 8, 9), make_array([1], [2]) || make_array([3], [4]);
Expand Down Expand Up @@ -358,6 +386,10 @@ select make_array(x, y) from foo2;
----
[1.0, 1]

# array_contains



# array_contains scalar function #1
query BBB rowsort
select array_contains(make_array(1, 2, 3), make_array(1, 1, 2, 3)), array_contains([1, 2, 3], [1, 1, 2]), array_contains([1, 2, 3], [2, 1, 3, 1]);
Expand Down Expand Up @@ -393,3 +425,80 @@ query BB rowsort
select array_contains(make_array(true, true, true), make_array(false, false)), array_contains([false, false, false], [true, true]);
----
false false

## array_contains array


statement ok
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to test nested arrays even more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in eb6e88f

CREATE TABLE t
AS VALUES
(make_array(1,2,3), make_array(1,2,3)),
(make_array(1,2,3), make_array(2,3)),
(make_array(2,3), make_array(1,2,3)),
(null, make_array(1,2,3)),
(make_array(2,3), null)
;


query ??
SELECT
column1,
column2
FROM t
----
[1, 2, 3] [1, 2, 3]
[1, 2, 3] [2, 3]
[2, 3] [1, 2, 3]
NULL [1, 2, 3]
[2, 3] NULL


# incorrect answer (one row) to https://github.com/apache/arrow-datafusion/issues/6709

query BB
SELECT
array_contains(column1, column2) as c12,
array_contains(column1, column2) as c21
FROM t
----
true true


statement ok
drop table t


## array_contains array (nested)


statement ok
CREATE TABLE t
AS VALUES
(make_array(make_array(2),make_array(3,4)), make_array(3,4)),
(make_array(make_array(2),make_array(3,4)), make_array(4,3)),
(make_array(make_array(2),make_array(3,4)), make_array(3)),
(make_array(make_array(2),make_array(3,4)), make_array(2))
;


query ??
SELECT
column1,
column2
FROM t
----
[[2], [3, 4]] [3, 4]
[[2], [3, 4]] [4, 3]
[[2], [3, 4]] [3]
[[2], [3, 4]] [2]


# incorrect answer (one row) to https://github.com/apache/arrow-datafusion/issues/6709

query BB
SELECT
array_contains(column1, column2) as c12,
array_contains(column1, column2) as c21
FROM t
----
true true