Add test for handling precision overflow when casting from integer to decimal #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
viirya
commented
Apr 18, 2023
Comment on lines
+596
to
+599
| query R | ||
| select try_cast(1234567 as decimal(7,3)); | ||
| ---- | ||
| NULL |
There was a problem hiding this comment.
I've verified that this returns incorrect result 1234.567 before the fix.
Dandandan
approved these changes
Apr 18, 2023
|
Thanks @Dandandan |
r4ntix
approved these changes
Apr 18, 2023
|
Thanks @viirya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5825.
Rationale for this change
What changes are included in this PR?
This issue was fixed at the upstream. Now adding a test for verification.
Are these changes tested?
Are there any user-facing changes?