Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer column nullability on joins #6015

Closed
wants to merge 0 commits into from
Closed

Conversation

comphead
Copy link
Contributor

@comphead comphead commented Apr 14, 2023

Which issue does this PR close?

Closes #5994 .

Fixes partially #5747

Rationale for this change

Fix bugs reported in #5994

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) labels Apr 14, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @comphead

This looks similar to #5748 (as mentioned in the ticket description)

I wonder if also fixes #5747 or #5695 🤔

@comphead comphead closed this Apr 18, 2023
@github-actions github-actions bot removed sqllogictest SQL Logic Tests (.slt) core Core DataFusion crate logical-expr Logical plan and expressions labels Apr 18, 2023
@comphead
Copy link
Contributor Author

oops I overwrote the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infer join side nullability for joined tables
2 participants