Move protoc generation to binary crate (#5718) #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we get a CI check, similar to https://github.com/apache/arrow-rs/pull/3927/files#diff-7a5f24a0bed6232c2297eba93812cdaeb26327ba955eabc0a04effc21e95d52bR65 |
tustvold
reviewed
Mar 26, 2023
Should I create another yaml or add check to existing one? |
|
I think adding it to https://github.com/apache/arrow-datafusion/blob/main/.github/workflows/rust.yml would make sense |
tustvold
reviewed
Mar 27, 2023
| uses: ./.github/actions/setup-builder | ||
| - name: Run gen | ||
| run: ./regen.sh | ||
| working-directory: ./datafusion/proto |
There was a problem hiding this comment.
This part shouldn't be necessary, as the script already handles this, but I suppose it can't hurt
tustvold
approved these changes
Mar 27, 2023
|
I verified this works great -- #5760 (comment) |
alamb
reviewed
Mar 27, 2023
| @@ -54,8 +54,3 @@ serde_json = { version = "1.0", optional = true } | |||
| [dev-dependencies] | |||
| doc-comment = "0.3" | |||
| tokio = "1.18" | |||
|
|
|||
| [build-dependencies] | |||
| # Pin these dependencies so that the generated output is deterministic | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5718
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?