-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update sqlparser requirement from 0.30 to 0.32 w/ API update #5457
Conversation
@ursabot benchmark help |
🤔 looks like some real problem in sql-parser upgrade -- I will investigate |
Specifically Fails with:
|
Upstream issue: apache/datafusion-sqlparser-rs#826 |
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. - [Release notes](https://github.com/sqlparser-rs/sqlparser-rs/releases) - [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md) - [Commits](apache/datafusion-sqlparser-rs@v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: sqlparser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
@andygrove if you have time to review this upgrade PR I would like to get it in prior to the release on Friday |
Thank you @appletreeisyellow and @tustvold ! |
Benchmark runs are scheduled for baseline = 8a1b133 and contender = 84530a2. 84530a2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #5451
Rationale for this change
New version of sqlparser was released and we need a few changes to DataFusion to acknowledge we don't support newly added syntax
What changes are included in this PR?
Changes from @dependabot in #5451 and updates to make ti compile
Are these changes tested?
Existing tests cover it
Are there any user-facing changes?
No