Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter pushdown for extension plans #5425

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Fix filter pushdown for extension plans #5425

merged 2 commits into from
Feb 28, 2023

Conversation

thinkharderdev
Copy link
Contributor

Which issue does this PR close?

Closes #5424

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

Predicates will be pushed down through extension plan nodes

No

@github-actions github-actions bot added the optimizer Optimizer rules label Feb 27, 2023
alamb
alamb approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @thinkharderdev - the code makes sense to me and I reviewed the test coverage carefully. Thanks again

datafusion/optimizer/src/push_down_filter.rs
.filter(col("a").eq(lit(1i64)).and(col("c").eq(lit(2i64))))?
.build()?;

// Push only predicate on `a` below NoopPlan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jackwener
jackwener approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice job, thanks @thinkharderdev

@thinkharderdev thinkharderdev merged commit c477fc0 into apache:main Feb 28, 2023
@thinkharderdev thinkharderdev deleted the filter-pushdown-fix branch February 28, 2023 13:02
@ursabot
Copy link

ursabot commented Feb 28, 2023

Benchmark runs are scheduled for baseline = c676d10 and contender = c477fc0. c477fc0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove added the bug Something isn't working label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@jackwener jackwener jackwener approved these changes

Assignees
No one assigned
Labels
bug Something isn't working optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Pushdown no longer works for extension plans
5 participants
@thinkharderdev @ursabot @alamb @jackwener @andygrove