-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: port predicates tests to sqllogictests #5374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot checked, LGTM
let ctx = SessionContext::new(); | ||
ctx.register_batch("test", batch)?; | ||
|
||
let sql = "SELECT * FROM test WHERE c1 LIKE '%a%'"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this one in the sqlogictest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, c1
-> column1
let ctx = SessionContext::new(); | ||
ctx.register_batch("test", batch)?; | ||
|
||
let sql = "SELECT * FROM test WHERE c1 LIKE '%a%'"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing in sqllogictest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, c1 -> column1
let ctx = SessionContext::new(); | ||
ctx.register_batch("test", batch)?; | ||
|
||
let sql = "SELECT * FROM test WHERE c1 ~ 'z'"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, c1 -> column1
Benchmark runs are scheduled for baseline = 49237a2 and contender = 05d8a25. 05d8a25 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #4495
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Add all tests
Are there any user-facing changes?