Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule ReplaceDistinctWithAggregate #5354

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Rule ReplaceDistinctWithAggregate #5354

merged 3 commits into from
Feb 25, 2023

Conversation

mingmwang
Copy link
Contributor

Which issue does this PR close?

Closes #5348.

Rationale for this change

Add a rule to replace the logical Distinct with the logical Aggregate, so that other logical rules do not need to handle Distinct additionally besides the Aggregate. This will simply the other logical rules, sometime they might handle the Aggregate but forget to handle Distinct.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Feb 21, 2023
@github-actions github-actions bot added the substrait Changes to the substrait crate label Feb 21, 2023
@mingmwang
Copy link
Contributor Author

retest please

@jackwener
Copy link
Member

jackwener commented Feb 22, 2023 •
edited
Loading

retest please

I have re-run the failed tests. Looks like something is wrong with GHA 😂

jackwener
jackwener approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great to me. Thanks @mingmwang

jackwener
jackwener reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no new review comments, I prepare to merge this PR in a day.

@jackwener jackwener merged commit a870e46 into apache:main Feb 25, 2023
@ursabot
Copy link

ursabot commented Feb 25, 2023

Benchmark runs are scheduled for baseline = 4d4c567 and contender = a870e46. a870e46 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener jackwener mentioned this pull request Feb 25, 2023
Merged
@ygf11 ygf11 mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwener jackwener jackwener approved these changes

@yjshen yjshen yjshen approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate optimizer Optimizer rules substrait Changes to the substrait crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a rule to replace distinct with aggregate
4 participants
@mingmwang @jackwener @ursabot @yjshen