Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't trigger rust ci for doc changes #5097

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Conversation

xudong963
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

push:
pull_request:
paths-ignore:
- "docs/**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think that the prettier checks run for doc changes

https://github.com/apache/arrow-datafusion/blob/master/.github/workflows/dev.yml#L39-L57

Perhaps we can add the trigger condition for that job so the markdown is checked when md files are modified?

Copy link
Member Author

@xudong963 xudong963 Jan 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think prettier checks will run for doc changes, here we only don't trigger rust ci for doc changes.

image

@alamb
Copy link
Contributor

alamb commented Jan 29, 2023

Thank you @xudong963

@xudong963 xudong963 merged commit 842bda3 into apache:master Jan 29, 2023
@xudong963 xudong963 deleted the ci branch January 29, 2023 10:59
@ursabot
Copy link

ursabot commented Jan 29, 2023

Benchmark runs are scheduled for baseline = 0f80bca and contender = 842bda3. 842bda3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants