Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVG(null) is NULL (not zero) #5008

Merged
merged 2 commits into from
Jan 21, 2023
Merged

AVG(null) is NULL (not zero) #5008

merged 2 commits into from
Jan 21, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 20, 2023 •
edited
Loading

Which issue does this PR close?

Closes #5007

Rationale for this change

Answer is incorrect

I started seeing this error when I upgraded IOx to https://github.com/influxdata/influxdb_iox/pull/6639 -- though I could reproduce the issue via datafusion cli even before that.

What changes are included in this PR?

AVG nulls is null

Are these changes tested?

yes

Are there any user-facing changes?

yes

@github-actions github-actions bot added core Core DataFusion crate physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Jan 20, 2023
ozankabak
ozankabak approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this made me think of the COUNT fix we made recently. Makes me think there may be some other minor gotchas like this lying around in the code, hopefully we will fix them soon.

@alamb
Copy link
Contributor Author

alamb commented Jan 20, 2023

LGTM, this made me think of the COUNT fix we made recently. Makes me think there may be some other minor gotchas like this lying around in the code, hopefully we will fix them soon.

Yeah, I originally thought it was related to #4924 (comment) 😆 but I think the refactor in group by simply exposed a latent issue

xudong963
xudong963 approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@xudong963 xudong963 merged commit f5439c8 into apache:master Jan 21, 2023
@ursabot
Copy link

ursabot commented Jan 21, 2023

Benchmark runs are scheduled for baseline = 9c11996 and contender = f5439c8. f5439c8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jonmmease pushed a commit to jonmmease/arrow-datafusion that referenced this pull request Jan 25, 2023
@alamb @jonmmease
AVG(null) is NULL (not zero) (apache#5008)
1e6438d 
* avg(null) should be null

* Fix code

(cherry picked from commit f5439c8)
@jonmmease jonmmease mentioned this pull request Jan 25, 2023
Closed
@alamb alamb deleted the alamb/avg_nulls branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozankabak ozankabak ozankabak approved these changes

@xudong963 xudong963 xudong963 approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVG(nulls) returns 0 rather than NULL
4 participants
@alamb @ursabot @ozankabak @xudong963