You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is confusing to get an error saying that field 't1.c0' does not exist but then states that field 't1.c0' is available. This happens when the qualifier is part of the field name and not in the qualifier field.
Before
No field named 't1.c0'. Valid fields are 't1.c0', ...
After
No field named 't1.c0'. Valid fields are 't1'.'c0', ...
What changes are included in this PR?
Change error message formating to put quotes around qualifier and name rather than around the qualified name, so 'foo'.'bar' rather than 'foo.bar'.
Benchmark runs are scheduled for baseline = 1a5f6ab and contender = 8cd6129. 8cd6129 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
Dandandan
pushed a commit
to yuuch/arrow-datafusion
that referenced
this pull request
Nov 5, 2022
api changeChanges the API exposed to users of the cratecoreCore DataFusion cratelogical-exprLogical plan and expressionssqlSQL Planner
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
core
Which issue does this PR close?
Closes #4083
Rationale for this change
It is confusing to get an error saying that field
't1.c0'does not exist but then states that field't1.c0' is available. This happens when the qualifier is part of the field name and not in the qualifier field.Before
After
What changes are included in this PR?
Change error message formating to put quotes around qualifier and name rather than around the qualified name, so
'foo'.'bar'rather than'foo.bar'.Are there any user-facing changes?