add uuid() function #4041
Merged
add uuid() function #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
reviewed
Oct 31, 2022
| @@ -157,6 +157,7 @@ pub fn return_type( | |||
| utf8_to_int_type(&input_expr_types[0], "octet_length") | |||
| } | |||
| BuiltinScalarFunction::Random => Ok(DataType::Float64), | |||
| BuiltinScalarFunction::Uuid => Ok(DataType::Utf8), | |||
There was a problem hiding this comment.
I wonder if we want to try and return bytes (DataType::Binary) instead of strings (and allow casting from bytes to string for anyone who wants strings) 🤔
There was a problem hiding this comment.
do you think binary is a better type than string? in this case the - delimited hex is a standardized form however using binary people might confuse with 16 byte array...?
| @@ -57,3 +57,4 @@ rand = "0.8" | |||
| regex = { version = "^1.4.3", optional = true } | |||
| sha2 = { version = "^0.10.1", optional = true } | |||
| unicode-segmentation = { version = "^1.7.1", optional = true } | |||
| uuid = { version = "^1.2", features = ["v4"] } | |||
There was a problem hiding this comment.
unlike the:
one i'd argue that uuid is a bit ubiquitous so this should be fine
alamb
reviewed
Nov 2, 2022
| let sql = "SELECT uuid()"; | ||
| let actual = execute(&ctx, sql).await; | ||
| let uuid = actual[0][0].parse::<uuid::Uuid>().unwrap(); | ||
| assert_eq!(uuid.get_version_num(), 4); |
Dandandan
pushed a commit
to yuuch/arrow-datafusion
that referenced
this pull request
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4045
Rationale for this change
add uuid() function
What changes are included in this PR?
Are there any user-facing changes?