Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Do what clippy says and clean up some code #4007

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 28, 2022

Which issue does this PR close?

N/A

Rationale for this change

clippy says it is infallible, which it is

So make it so and remove some ?

What changes are included in this PR?

Fix a clippy lint

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Oct 28, 2022
@alamb alamb marked this pull request as draft October 28, 2022 20:57
@alamb alamb marked this pull request as ready for review October 29, 2022 11:48
@jackwener
Copy link
Member

I can't find this ability of clippy in doc, Can I ask how to use it?

@alamb
Copy link
Contributor Author

alamb commented Oct 30, 2022

I can't find this ability of clippy in doc, Can I ask how to use it?

I am not sure what you mean

In this case I found that someone had left a "#allow" command in the code (which ignores something clippy would normally flag a a warning). I removed the "allow" and then updated the code so clippy passed.

@jackwener
Copy link
Member

In this case I found that someone had left a "#allow" command in the code (which ignores something clippy would normally flag a a warning). I removed the "allow" and then updated the code so clippy passed.

😂

@andygrove andygrove merged commit f4d70ac into apache:master Oct 30, 2022
@ursabot
Copy link

ursabot commented Oct 30, 2022

Benchmark runs are scheduled for baseline = d6f0b12 and contender = f4d70ac. f4d70ac is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/random_cleanup2 branch October 31, 2022 10:56
jimexist pushed a commit to jimexist/arrow-datafusion that referenced this pull request Oct 31, 2022
Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants