Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix on DFField to Field conversion: preserve metadata #3965

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Bug fix on DFField to Field conversion: preserve metadata #3965

merged 1 commit into from
Oct 27, 2022

Conversation

metesynnada
Copy link
Contributor

Which issue does this PR close?

Closes #3964.

Rationale for this change

While converting DFSchema to Schema, field metadata is not preserved. It may cause future bugs on methods like alias.

What changes are included in this PR?

Changing From<DFSchema> for Schema method.

Are there any user-facing changes?

NA

@alamb alamb changed the title Bug fix on DFField to Field conversion Bug fix on DFField to Field conversion: preserve metadata Oct 27, 2022
alamb
alamb approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @metesynnada -- this looks great

datafusion/common/src/dfschema.rs
}
})
.collect(),
df_schema.fields.into_iter().map(|f| f.field).collect(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for fixing a bug by deleting code

@andygrove andygrove merged commit e73a43c into apache:master Oct 27, 2022
@ursabot
Copy link

ursabot commented Oct 27, 2022

Benchmark runs are scheduled for baseline = 8792a01 and contender = e73a43c. e73a43c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@metesynnada @Dandandan
Bug fix on DFField to Field conversion (apache#3965)
c97d34c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug on propagating arrow field metadata
4 participants
@metesynnada @ursabot @alamb @andygrove