Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Informative Error Message for LAG and LEAD functions #3963

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Informative Error Message for LAG and LEAD functions #3963

merged 5 commits into from
Oct 27, 2022

Conversation

mustafasrepo
Copy link
Contributor

Which issue does this PR close?

Improves the #3830 .

Rationale for this change

We have added an error message (instead of panicking) to inform user.

What changes are included in this PR?

Test case reproducing the problem at #3830 is added.

Are there any user-facing changes?

N.A

@github-actions github-actions bot added the core Core DataFusion crate label Oct 26, 2022
alamb
alamb approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mustafasrepo

@github-actions github-actions bot removed the core Core DataFusion crate label Oct 27, 2022
@mustafasrepo
Merge branch 'feature/window_frame_lag' of https://github.com/synnada…
4d6a455 
…-ai/arrow-datafusion into feature/window_frame_lag

# Conflicts:
#	datafusion/core/tests/sql/window.rs
@mustafasrepo mustafasrepo reopened this Oct 27, 2022
@github-actions github-actions bot added the core Core DataFusion crate label Oct 27, 2022
@mustafasrepo mustafasrepo reopened this Oct 27, 2022
@github-actions github-actions bot removed the core Core DataFusion crate label Oct 27, 2022
@mustafasrepo mustafasrepo reopened this Oct 27, 2022
@github-actions github-actions bot added the core Core DataFusion crate label Oct 27, 2022
@alamb alamb merged commit 4b5d720 into apache:master Oct 27, 2022
@alamb alamb mentioned this pull request Oct 27, 2022
Closed
@ursabot
Copy link

ursabot commented Oct 27, 2022

Benchmark runs are scheduled for baseline = c505739 and contender = 4b5d720. 4b5d720 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@mustafasrepo @Dandandan
Informative Error Message for LAG and LEAD functions (apache#3963)
b0ce95d 
* panic is changed to error for lag and lead functions

* remove unnecessary changes

* remove unnecessary changes
@mustafasrepo mustafasrepo deleted the feature/window_frame_lag branch November 28, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustafasrepo @ursabot @alamb