Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move simplify_expression.rs and expr_simplifier.rs to a new mod simplify_expressions #3951

Merged
merged 9 commits into from
Oct 26, 2022
Merged

Refactor: move simplify_expression.rs and expr_simplifier.rs to a new mod simplify_expressions #3951

merged 9 commits into from
Oct 26, 2022

Conversation

HaoYang670
Copy link
Contributor

@HaoYang670 HaoYang670 commented Oct 25, 2022 •
edited
Loading

Which issue does this PR close?

Closes #3934.

Rationale for this change

Please look at the #3934

What changes are included in this PR?

Create a new mod simplify_exprsssions:

  • simplify_exprs: contains SimplifyExpressions and tests
  • expr_simplifier: contains ExprSimplifier, ConstEvalutor, Simplifier and tests
  • context: contains simplifyInfo and SimplifyContext
  • utils: utility functions
  • ConstEvalutor and Simplifier are marked as private now

Are there any user-facing changes?

Yes. ConstEvalutor and Simplifier are no longer public

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Oct 25, 2022
@HaoYang670 HaoYang670 changed the title Refactor: move simplify_expression.rs and expr_simplifier.rs to a new mod simplify_exprs Refactor: move simplify_expression.rs and expr_simplifier.rs to a new mod simplify_expressions Oct 25, 2022
@HaoYang670 HaoYang670 requested a review from alamb October 25, 2022 05:45
@HaoYang670
Copy link
Contributor Author

@alamb PTAL. Thank you!

@HaoYang670
fix merge conflict
f96d57d 
Signed-off-by: remzi <[email protected]>
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Oct 25, 2022
@HaoYang670 HaoYang670 added the api change Changes the API exposed to users of the crate label Oct 25, 2022
alamb
alamb approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is great -- thank you @HaoYang670 . I was thinking the other day that the names of these modules was super confusing.

@andygrove andygrove self-requested a review October 25, 2022 17:34
@andygrove andygrove merged commit 10e64dc into apache:master Oct 26, 2022
@HaoYang670 HaoYang670 deleted the 3934_refactor_simplify_exprs branch October 26, 2022 01:16
@ursabot
Copy link

ursabot commented Oct 26, 2022

Benchmark runs are scheduled for baseline = 784f10b and contender = 10e64dc. 10e64dc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@HaoYang670 @Dandandan
Refactor: move simplify_expression.rs and expr_simplifier.rs to a…
323a5d9 
… new mod `simplify_expressions` (apache#3951)

* create mod for expr_simpl

Signed-off-by: remzi <[email protected]>

* move utility to utils

Signed-off-by: remzi <[email protected]>

* create context mod

Signed-off-by: remzi <[email protected]>

* add docs for context

Signed-off-by: remzi <[email protected]>

* move constEvalutor to expr_simplififer

Signed-off-by: remzi <[email protected]>

* move simplifier to expr_simplifier

Signed-off-by: remzi <[email protected]>

* fix lints

Signed-off-by: remzi <[email protected]>

* fix merge conflict

Signed-off-by: remzi <[email protected]>

Signed-off-by: remzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@andygrove andygrove Awaiting requested review from andygrove

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor simplify_expressions and expr_simplifier
4 participants
@HaoYang670 @ursabot @alamb @andygrove