Update to arrow 25.0.0 #3844
Merged
Update to arrow 25.0.0 #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
tustvold
force-pushed
the
update-arrow-25
branch
from
c3b2d86 to
acac87b
Compare
Dandandan
reviewed
Oct 15, 2022
Comment on lines
63
to
64
| if mul_col { | ||
| for (i, hash) in hashes_buffer.iter_mut().enumerate() { |
There was a problem hiding this comment.
I think we can we use hash_array here now instead?
There was a problem hiding this comment.
Potentially, I think I would rather keep this as a simple upgrade PR, and address any simplifications that fall out of the new decimal abstractions as a follow up
6 tasks
tustvold
force-pushed
the
update-arrow-25
branch
from
acac87b to
75ac73f
Compare
Dandandan
approved these changes
Oct 18, 2022
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?