move type coercion of agg and agg_udaf to logical phase #3768
Conversation
github-actions
bot
added
core
|
PTAL @alamb |
| @@ -1,54 +0,0 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
| ); | ||
| let udaf = Expr::AggregateUDF { | ||
| fun: Arc::new(my_avg), | ||
| args: vec![lit(10i64)], |
| let mut config = OptimizerConfig::default(); | ||
| let plan = rule.optimize(&plan, &mut config)?; | ||
| assert_eq!( | ||
| "Projection: AVG(Int64(12))\n EmptyRelation", |
There was a problem hiding this comment.
I don't see any coercion happening here. Maybe I am missing something
There was a problem hiding this comment.
Yes, you didn't missing anything.
You can take a look type_coercion::aggregates::coerce_types function which just check the input data type and don't do any coercion for the function.
|
Benchmark runs are scheduled for baseline = f132259 and contender = 053dc5a. 053dc5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3752
Closes #3623
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?