Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlparser-0.21] Update planning of LIKE expressions #3194

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Aug 18, 2022

Which issue does this PR close?

Part of #3192

Rationale for this change

Keeping up with changes in sqlparser

What changes are included in this PR?

  • Like is now a top-level expression
  • Ignored a failing test that we cannot fix until we upgrade to a newer version of sqlparser

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Aug 18, 2022
@andygrove andygrove changed the title Sqlparser like changes Update planning of LIKE expressions due to changes in sqlparser Aug 18, 2022
@andygrove andygrove mentioned this pull request Aug 18, 2022
5 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #3194 (97c486c) into sqlparser-0.21 (929eb6d) will decrease coverage by 0.03%.
The diff coverage is 51.35%.

❗ Current head 97c486c differs from pull request most recent head 5f4d736. Consider uploading reports for the commit 5f4d736 to get more accurate results

@@                Coverage Diff                 @@
##           sqlparser-0.21    #3194      +/-   ##
==================================================
- Coverage           85.87%   85.84%   -0.04%     
==================================================
  Files                 291      291              
  Lines               52885    52898      +13     
==================================================
- Hits                45415    45410       -5     
- Misses               7470     7488      +18     
Impacted Files Coverage Δ
datafusion/core/tests/sql/expr.rs 99.84% <ø> (-0.01%) ⬇️
datafusion/sql/src/planner.rs 80.75% <51.35%> (-0.50%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.60% <0.00%> (-0.18%) ⬇️
datafusion/physical-expr/src/expressions/binary.rs 97.59% <0.00%> (-0.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove andygrove changed the title Update planning of LIKE expressions due to changes in sqlparser [sqlparser-0.21] Update planning of LIKE expressions Aug 18, 2022
@alamb
Copy link
Contributor

alamb commented Aug 18, 2022

I think this one needs to be rebased

@andygrove andygrove force-pushed the sqlparser-like-changes branch from 5f4d736 to 49900e4 Compare August 18, 2022 19:09
@andygrove
Copy link
Member Author

@alamb This is now rebased

@andygrove andygrove merged commit 578ea1a into apache:sqlparser-0.21 Aug 18, 2022
@andygrove andygrove deleted the sqlparser-like-changes branch August 18, 2022 19:58
alamb pushed a commit that referenced this pull request Aug 19, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (#3193)

* Update planning for LIKE due to changes in sqlparser (#3194)

* rename array function to make_array (#3199)

* [sqlparser-0.21] Update trimExpr members during planning (#3181)

* Update sqlparser version to use main from git

* Update SqlExpr::Trim struct to match latest sqlparser changes

* use sqlparser 0.21 (#3202)

Co-authored-by: Ayush Dattagupta <[email protected]>
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)

* Update planning for LIKE due to changes in sqlparser (apache#3194)

* rename array function to make_array (apache#3199)

* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)

* Update sqlparser version to use main from git

* Update SqlExpr::Trim struct to match latest sqlparser changes

* use sqlparser 0.21 (apache#3202)

Co-authored-by: Ayush Dattagupta <[email protected]>
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)

* Update planning for LIKE due to changes in sqlparser (apache#3194)

* rename array function to make_array (apache#3199)

* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)

* Update sqlparser version to use main from git

* Update SqlExpr::Trim struct to match latest sqlparser changes

* use sqlparser 0.21 (apache#3202)

Co-authored-by: Ayush Dattagupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants