allow datafusion-cli to take a file param #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 76.16% 76.07% -0.10%
==========================================
Files 140 140
Lines 23603 23632 +29
==========================================
Hits 17978 17978
- Misses 5625 5654 +29
Continue to review full report at Codecov.
|
|
|
|
|
jimexist
force-pushed
the
add-file-mode-to-datafusion-cli
branch
from
24ba9a0 to
5582f18
Compare
jorgecarleitao
approved these changes
May 8, 2021
jimexist
commented
May 8, 2021
| ExecutionContext::with_config(execution_config.with_information_schema(true)); | ||
| if let Some(file_path) = matches.value_of("file") { | ||
| let file = File::open(file_path) | ||
| .unwrap_or_else(|err| panic!("cannot open file '{}': {}", file_path, err)); |
There was a problem hiding this comment.
example error for when file is not readable
❯ cargo run --release --bin datafusion-cli -q -- -f ./1.sql
thread 'main' panicked at 'cannot open file './1.sql': Permission denied (os error 13)', datafusion-cli/src/main.rs:82:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
0789a4f to
e57ecce
Compare
jimexist
changed the title
|
Looks really good -- thanks @jimexist |
alamb
approved these changes
May 8, 2021
houqp
added
datafusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #282.
Relies on #283
Rationale for this change
Allow datafusion-cli to take file as a param.
What changes are included in this PR?
See above
Are there any user-facing changes?
User facing changes are the sole addition of such flag.