minor: simplify union_extract code
#14640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
github-actions
bot
removed
documentation
github-actions
bot
added
the
documentation
gstvg
reviewed
Feb 15, 2025
| @@ -113,22 +114,15 @@ impl ScalarUDFImpl for UnionExtractFun { | |||
| } | |||
|
|
|||
| fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { | |||
| let args = args.args; | |||
| let [array, target_name] = take_function_args("union_extract", args.args)?; | |||
gstvg
reviewed
Feb 15, 2025
| } | ||
| _ => ScalarValue::try_from(target.data_type())?, | ||
| Some((type_id, value)) if target_type_id == type_id => *value, | ||
| _ => ScalarValue::try_new_null(target.data_type())?, |
gstvg
approved these changes
Feb 15, 2025
github-actions
bot
removed
the
documentation
xudong963
approved these changes
Feb 17, 2025
|
Thanks @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
There were a few simplifications I noticed while reviewing #12116 so I am
What changes are included in this PR?
take_function_argsin more places #14525 and usestake_function_argsfrom @findepi ❤️Are these changes tested?
Are there any user-facing changes?