Migrate code from invoke to invoke_batch. #13345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @findepi |
findepi
reviewed
Nov 10, 2024
| ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)), | ||
| ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)), | ||
| ], | ||
| 0, |
There was a problem hiding this comment.
would 1 be more suitable?
(same in other places)
jayzhan211
approved these changes
Nov 13, 2024
|
Thank you very much @irenjj and @findepi and @jayzhan211 -- I merged this branch up from main to run CI against the latest and greatest versions |
|
Thank you @irenjj @jayzhan211 @alamb . |
wiedld
added a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jan 7, 2025
This reverts commit 66180fa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13238
Rationale for this change
What changes are included in this PR?
Migrate code in unit test from invoke to invoke_batch.
Are these changes tested?
yes
Are there any user-facing changes?
no