Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant unsafe in test #12914

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Remove redundant unsafe in test #12914

merged 1 commit into from
Oct 15, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 13, 2024

Unsafe StructArray::new_unchecked is a more performant alternative to StructArray::new. In test code there is no benefit from using the unsafe code path.

@findepi
Remove redundant unsafe in test
61cdc7f 
Unsafe `StructArray::new_unchecked` is a more performant alternative to
`StructArray::new`. In test code there is no benefit from using the
unsafe code path.
@github-actions github-actions bot added the common Related to common crate label Oct 13, 2024
alamb
alamb approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- this makes sense to me

@alamb alamb merged commit 4a0b768 into apache:main Oct 15, 2024
24 checks passed
@findepi findepi deleted the findepi/remove-redundant-unsafe-in-test-423565 branch October 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
common Related to common crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @alamb