Require Debug for PhysicalOptimizerRule
#12624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add the |
|
Thank you @AnthonyZhOon -- this looks super helpful |
alamb
approved these changes
Sep 25, 2024
|
Looks like there are some small CI failures to address @AnthonyZhOon |
… informs this is unnecessary This reverts commit f69d73c.
|
Okay, clippy lint should be fixed with the revert @alamb , odd that rust-analyzer misled me on the types at the time maybe it was an incomplete compile |
|
I think this one is minor enough and non controversial I will merge it in, even though it is an API change |
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
* Require Debug for PhysicalOptimizerRule * Add reference to meet &JoinType type required * Revert "Add reference to meet &JoinType type required" as clippy lint informs this is unnecessary This reverts commit f69d73c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12555
Rationale for this change
Supporting SessionStateBuilder to implement Debug
What changes are included in this PR?
Debugfor PhysicalOptimizerRule#deriveDebug where necessary3. Add a&to take a&JoinTypeinEnforceDistribution(not sure why this wasn't acargo checkerror but rust-analyzer showed it and types seem to require it)Are these changes tested?
By CI and the compiler
Are there any user-facing changes?
API change for
PhysicalOptimizerRulewhich now requires Debug