feat: Add support for Int8 and Int16 data types in data page statistics #10931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinlanhenke
approved these changes
Jun 16, 2024
alamb
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Thank you @Weijun-H (and @marvinlanhenke for the review 🙏 )
This PR has a merge conflict now (likely due to #10927)
Weijun-H
force-pushed
the
Support-extracting-Int8,-Int16,-Int32-statistics-from-Parquet-Data-Pages
branch
from
7d9a556 to
ce22d2e
Compare
alamb
approved these changes
Jun 17, 2024
| @@ -573,16 +568,6 @@ async fn test_int_16() { | |||
| Test { | |||
| reader: &reader, | |||
| // mins are [-5, -4, 0, 5] | |||
| // BUG: not sure why this returns same data but in Int32Array type even though I debugged and the columns name is "i16" an its data is Int16 | |||
This was referenced Jun 17, 2024
This was referenced Jun 20, 2024
This was referenced Jun 30, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10928
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?