Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of deprecated dict_id in datafusion-proto #14173

Closed
alamb opened this issue Jan 17, 2025 · 1 comment · Fixed by #14227
Closed

Remove use of deprecated dict_id in datafusion-proto #14173

alamb opened this issue Jan 17, 2025 · 1 comment · Fixed by #14227
Assignees
@cj-zhukov
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 17, 2025 •
edited
Loading

Is your feature request related to a problem or challenge?

The most recent version of arrow deprecates the dictionary fields from Schema, see

You can see the rationale from @brancz here (it is basically not used):

We should remove the use of the deprecated fields before it is fully removed in some future arrow-rs version

Describe the solution you'd like

I think we simply need to remove the code that serializes and deserialzed the dict_id related fields

Describe alternatives you've considered

No response

Additional context

No response
@alamb alamb added the enhancement New feature or request label Jan 17, 2025
This was referenced Jan 17, 2025
Merged
Merged
@cj-zhukov
Copy link
Contributor

take

cj-zhukov pushed a commit to cj-zhukov/datafusion that referenced this issue Jan 22, 2025
Remove use of deprecated dict_id in datafusion-proto (apache#14173)
f1c1ca9
@cj-zhukov cj-zhukov mentioned this issue Jan 22, 2025
Merged
alamb added a commit that referenced this issue Feb 11, 2025
@cj-zhukov @alamb
Remove use of deprecated dict_id in datafusion-proto (#14173) (#14227)
c0e78d2 
* Remove use of deprecated dict_id in datafusion-proto (#14173)

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* Fix issues causing GitHub checks to fail

* remove accidental file

* undo deletion of test in copy.slt

* Fix issues causing GitHub checks to fail

---------

Co-authored-by: Sergey Zhukov <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cj-zhukov cj-zhukov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of deprecated dict_id in datafusion-proto (#14173) cj-zhukov/datafusion
2 participants
@alamb @cj-zhukov