Add support for AT TIME ZONE
#539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Jul 18, 2022
| @@ -285,6 +285,11 @@ pub enum Expr { | |||
| expr: Box<Expr>, | |||
| data_type: DataType, | |||
| }, | |||
| /// AT a timestamp to a different timezone e.g. `FROM_UNIXTIME(0) AT TIME ZONE 'UTC-06:00'` | |||
There was a problem hiding this comment.
Pull Request Test Coverage Report for Build 2691581309
💛 - Coveralls |
bitemyapp
force-pushed
the
bitemyapp/add-support-for-at-time-zone
branch
from
f2a33a7 to
9d12e85
Compare
bitemyapp
force-pushed
the
bitemyapp/add-support-for-at-time-zone
branch
from
9d12e85 to
0a897d2
Compare
|
@alamb rebases all around, fmt issues should be fixed now. |
alamb
approved these changes
Jul 18, 2022
|
Thank you @bitemyapp ! |
mobuchowski
pushed a commit
to mobuchowski/sqlparser-rs
that referenced
this pull request
Aug 3, 2022
* Support for empty array literals * Added support for AT TIME ZONE Co-authored-by: Chris Allen <[email protected]>
gandronchik
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 6, 2022
* Support for empty array literals * Added support for AT TIME ZONE Co-authored-by: Chris Allen <[email protected]> qwe
gandronchik
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 6, 2022
* Support for empty array literals * Added support for AT TIME ZONE Co-authored-by: Chris Allen <[email protected]> qwe
mcheshkov
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 2, 2024
* Support for empty array literals * Added support for AT TIME ZONE Co-authored-by: Chris Allen <[email protected]> Can drop this after rebase on commit 7cbbd91 "Add support for AT TIME ZONE (apache#539)", first released in 0.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #532, this time to add support for
AT TIME ZONEwhich appears in multiple SQL dialects including Athena/Presto and MSSQL. There may be others, I haven't bothered to check. I can rebase if #532 gets merged first.This one was a bit harder. The precedence value is pure guessery: "uhhhh kinda looks like
BETWEEN?"All tests passed locally 🤞