Parse signed/unsigned integer data types correctly in MySQL CAST #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL doesn't have the same set of possible CAST types as for e.g. column definitions. For example, it raises a syntax error for `CAST(1 AS INTEGER SIGNED)` and instead expects `CAST(1 AS SIGNED INTEGER)`. This patch takes a somewhat unfortunate route of 1) adding a boolean flag that modifies the `parse_data_type` match expression, and 2) storing whether it was parsed this way in the `Expr::Cast` AST node to be used during formatting. Feedback and ideas for alternative approaches are very welcome. Closes apache#1589
mvzink
force-pushed
the
push-vlqruupookvx
branch
from
9616c36 to
b84315a
Compare
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this pull request
Feb 22, 2025
See relevant sqlparser [PR]. [PR]: apache/datafusion-sqlparser-rs#1739 Change-Id: I11a01b48f1649c6530cdbe7bd23c158e9fe4f888
iffyio
reviewed
Feb 23, 2025
| format: Option<CastFormat>, | ||
| /// Whether this was parsed as a [MySQL]-style cast, which has a different syntax for |
There was a problem hiding this comment.
would it be possible to instead add the DataType variants that mysql uses? It seems like one issue is that the existing signed/unsigned datatypes aren't matching their expected string output. for example Datatype::UnsignedInteger outputs itself as INTEGER UNSIGNED.
Thinking expectation behaviour could be that we introduce
DataType::IntegerUnsigned => INTEGER UNSIGNED
and update
DataType::UnsignedInteger => UNSIGNED INTEGER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL doesn't have the same set of possible CAST types as for e.g. column definitions. For example, it raises a syntax error for
CAST(1 AS INTEGER SIGNED)and instead expectsCAST(1 AS SIGNED INTEGER).This patch takes a somewhat unfortunate route of 1) adding a boolean flag that modifies the
parse_data_typematch expression, and 2) storing whether it was parsed this way in theExpr::CastAST node to be used during formatting. Feedback and ideas for alternative approaches are very welcome.Closes #1589