-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document round trip ability #1052
Conversation
Pull Request Test Coverage Report for Build 7008526520Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Do you have any comments about this @Dandandan / @andygrove ? |
Thank you @andygrove |
Should comments be mentioned as another exception? In my brief test, comments didn't seem to be present in the AST (and I wouldn't particularly expect them) - but maybe that's planned, or there's an option I've overlooked. |
I agree comments should be another exception |
Rationale
The property that the crate attempts to preserve "round trip ability" has come up in several PRs, most recently with @takluyver last week
Changes
parse_sql_statements
that theverified*
variants should be preferedThere are no code changes in this PR