Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: udaf: enable multiple column input #546

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

dlovell
Copy link
Contributor

@dlovell dlovell commented Dec 8, 2023

Which issue does this PR close?

This PR does not close an issue but propagates the work of apache/datafusion#7096 to arrow-datafusion-python

Rationale for this change

The functionality already exists in the underlying rust but is not exposed to the python interface.

What changes are included in this PR?

udaf still accepts a single pa.lib.DataType as an input, but also accepts an iterable of pa.lib.DataType

Are there any user-facing changes?

All previously working code will still work the same.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dlovell

@andygrove andygrove merged commit 76d7fcf into apache:main Dec 28, 2023
@dlovell dlovell deleted the udaf-multiple-column-input branch February 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants