Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify tarball installation #959

Merged
merged 4 commits into from
Sep 24, 2024
Merged

chore: clarify tarball installation #959

merged 4 commits into from
Sep 24, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Describe installation steps from Published Source Release

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@comphead comphead requested a review from andygrove September 23, 2024 18:25
- 3.3
- 3.4
- 3.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we fully supporting 4.0? I can see the build maven profile for 4.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not fully supported yet

@@ -44,8 +49,21 @@ There are no published JAR files yet.

Official source releases can be downloaded from https://dist.apache.org/repos/dist/release/datafusion/

Building from a source release is mostly the same as building directly from the GitHub repository but requires the
use of the command `make release-nogit` instead of `make release`.
Download the latest Apache DataFusion Comet tarball file from `datafusion-comet-1.2.3` folder. For example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we can use x.y.z or *.*.* instead of 1.2.3 because the sentence is generic, not specific about an example.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comphead

@andygrove andygrove merged commit 8410c71 into apache:main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants