-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable Comet shuffle for Spark core-1 test #924
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #924 +/- ##
============================================
+ Coverage 34.03% 34.15% +0.11%
+ Complexity 883 882 -1
============================================
Files 113 112 -1
Lines 43170 43237 +67
Branches 9516 9562 +46
============================================
+ Hits 14693 14766 +73
+ Misses 25471 25455 -16
- Partials 3006 3016 +10 ☔ View full report in Codecov by Sentry. |
Seems negative ref count issue was fixed by previous commits revising array import/export. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @viirya
1 minor why we have RUST_BACKTRACE enabled for ansi workflow test and disabled for regular one?
Which issue does this PR close?
Closes #930.
Rationale for this change
We disabled Comet shuffle for Spark core-1 test because negative ref count issue reported by Java Arrow. After fixing memory issues and some changes to more follow C Data interface, we may re-enable Comet shuffle for Spark core-1 test in CI.
What changes are included in this PR?
How are these changes tested?