build: Add maven-compiler-plugin for java cross-build

[viirya]

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

[viirya]

cc @huaxingao I guess that we need this to make a Comet build on Java 17 builder to be built with Iceberg on Java 11.

[viirya]

After @huaxingao tested it, this doesn't help on the issue. I will close this for now.

[viirya]

Wait for re-verifying

cc @huaxingao

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.01%. Comparing base (033fe6f) to head (0784bab).
Report is 10 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #911      +/-   ##
============================================
- Coverage     34.03%   34.01%   -0.03%     
+ Complexity      883      875       -8     
============================================
  Files           113      112       -1     
  Lines         43170    43221      +51     
  Branches       9516     9563      +47     
============================================
+ Hits          14693    14701       +8     
- Misses        25471    25491      +20     
- Partials       3006     3029      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[parthchandra]

Seems to be the right thing to do irrespective of whether it addresses the iceberg build issue.

[viirya]

Thanks @parthchandra .

[viirya]

Thanks @andygrove @huaxingao @parthchandra

[parthchandra]

Just realized that we already had

    <maven.compiler.source>${java.version}</maven.compiler.source>
    <maven.compiler.target>${java.version}</maven.compiler.target>

which set these properties for the compiler plugin. So it appears we are not adding anything new, which may explain why this did not help.

There is a new property available since JDK 9 which we could use (and also remove the jdk 1.8 profile which is meaningless if the source and target version are set to 11 or greater)

<maven.compiler.release>${java.version}</maven.compiler.release>

https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html

@huaxingao