chore: change shuffle mode default from jvm to auto #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Aug 28, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* change shuffle mode default from jvm to auto * update expected plans for Spark 3.4 * update expected plans for Spark 3.5 * fix docs for default value * update expected plans for Spark 4.0 * update expected plans for Spark 4.0 * update 3.4 plans (cherry picked from commit fe35224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Setting shuffle mode to
autowill choose the optimal shuffle mechanism (eithernativeorjvmdepending on the plan). This makes more sense as the default value rather than pickingjvmwhich will prevent the use of the more efficientnativeshuffle in some cases.The plans got smaller in this PR:
What changes are included in this PR?
jvmtoautoHow are these changes tested?
Existing tests.