chore: Use Git tag as Comet version when publishing Docker images #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Aug 21, 2024
| @@ -44,8 +44,7 @@ jobs: | |||
| - name: Extract Comet version | |||
| id: extract_version | |||
| run: | | |||
| COMET_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout) | |||
| echo "COMET_VERSION=$COMET_VERSION" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
$COMET_VERSION somehow evaluated to 1 here
|
@edmondop Could you review? |
andygrove
changed the title
viirya
approved these changes
Aug 21, 2024
viirya
reviewed
Aug 21, 2024
| COMET_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout) | ||
| echo "COMET_VERSION=$COMET_VERSION" >> $GITHUB_ENV | ||
| # use the tag that triggered this workflow as the Comet version e.g. 0.2.0-rc1 | ||
| echo "COMET_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Is this to fix ghcr.io/apache/datafusion-comet:spark-3.4-scala-2.12-1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?