chore: Make it possible to run 'make benchmark-%' using jvm 17+ #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using jvm 17+ spark needs extra jvm args to avoid getting errors like ``` [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.2.0:java (default-cli) on project comet-spark-spark3.4_2.12: An exception occurred while executing the Java class. class org.apache.spark.storage.StorageUtils$ (in unnamed module @0x35b75242) cannot access class sun.nio.ch.DirectBuffer (in module java.base) because module java.base does not export sun.nio.ch to unnamed module @0x35b75242 -> [Help 1] ``` These args are already present inside the main pom.xml. To avoid duplicating the args we using maven to extract them. In order avoid slowing down the Makefile the args are defined as a function and therefore only evaluated when they are needed.
eejbyfeldt
changed the title
andygrove
approved these changes
Aug 13, 2024
andygrove
reviewed
Aug 13, 2024
| @@ -80,7 +84,7 @@ release: | |||
| release-nogit: | |||
| cd native && RUSTFLAGS="-Ctarget-cpu=native" cargo build --release | |||
| ./mvnw install -Prelease -DskipTests $(PROFILES) -Dmaven.gitcommitid.skip=true | |||
| benchmark-%: clean release | |||
| cd spark && COMET_CONF_DIR=$(shell pwd)/conf MAVEN_OPTS='-Xmx20g' ../mvnw exec:java -Dexec.mainClass="$*" -Dexec.classpathScope="test" -Dexec.cleanupDaemonThreads="false" -Dexec.args="$(filter-out $@,$(MAKECMDGOALS))" $(PROFILES) | |||
| benchmark-%: release | |||
viirya
approved these changes
Aug 13, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
When using jvm 17+ spark needs extra jvm args to avoid getting errors like ``` [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.2.0:java (default-cli) on project comet-spark-spark3.4_2.12: An exception occurred while executing the Java class. class org.apache.spark.storage.StorageUtils$ (in unnamed module @0x35b75242) cannot access class sun.nio.ch.DirectBuffer (in module java.base) because module java.base does not export sun.nio.ch to unnamed module @0x35b75242 -> [Help 1] ``` These args are already present inside the main pom.xml. To avoid duplicating the args we using maven to extract them. In order avoid slowing down the Makefile the args are defined as a function and therefore only evaluated when they are needed. (cherry picked from commit a0734dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
When using jvm 17+ spark needs extra jvm args to avoid getting errors like
What changes are included in this PR?
These args are already present inside the main pom.xml. To avoid duplicating the args we using maven to extract them. In order avoid slowing down the Makefile the args are defined as a function and therefore only evaluated when they are needed.
How are these changes tested?
Manually running the make commands using jvm 17.