fix: Sort on single struct should fallback to Spark #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
============================================
- Coverage 33.94% 33.80% -0.14%
+ Complexity 874 870 -4
============================================
Files 112 112
Lines 42916 42914 -2
Branches 9464 9452 -12
============================================
- Hits 14567 14507 -60
- Misses 25379 25428 +49
- Partials 2970 2979 +9 ☔ View full report in Codecov by Sentry. |
huaxingao
reviewed
Aug 12, 2024
| | spark.comet.scan.enabled | Whether to enable Comet scan. When this is turned on, Spark will use Comet to read Parquet data source. Note that to enable native vectorized execution, both this config and 'spark.comet.exec.enabled' need to be enabled. By default, this config is true. | true | | ||
| | spark.comet.scan.preFetch.enabled | Whether to enable pre-fetching feature of CometScan. By default is disabled. | false | | ||
| | spark.comet.scan.preFetch.threadNum | The number of threads running pre-fetching for CometScan. Effective if spark.comet.scan.preFetch.enabled is enabled. By default it is 2. Note that more pre-fetching threads means more memory requirement to store pre-fetched row groups. | 2 | | ||
| | spark.comet.shuffle.preferDictionary.ratio | The ratio of total values to distinct values in a string column to decide whether to prefer dictionary encoding when shuffling the column. If the ratio is higher than this config, dictionary encoding will be used on shuffling string column. This config is effective if it is higher than 1.0. By default, this config is 10.0. Note that this config is only used when `spark.comet.exec.shuffle.mode` is `jvm`. | 10.0 | | ||
| | spark.comet.sparkToColumnar.supportedOperatorList | A comma-separated list of operators that will be converted to Comet columnar format when 'spark.comet.sparkToColumnar.enabled' is true | Range,InMemoryTableScan | |
There was a problem hiding this comment.
nit: Shall we use ` instead of '
There was a problem hiding this comment.
This is not changed by this PR. I think there is previous PR changing it, but didn't update the document.
There was a problem hiding this comment.
The document is updated automatically when make release locally.
huaxingao
approved these changes
Aug 12, 2024
|
Thanks @huaxingao |
andygrove
reviewed
Aug 12, 2024
| @@ -2501,6 +2501,13 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim | |||
|
|
|||
| case SortExec(sortOrder, _, child, _) | |||
| if isCometOperatorEnabled(op.conf, CometConf.OPERATOR_SORT) => | |||
| // TODO: Remove this constraint when we upgrade to new arrow-rs including | |||
| // https://github.com/apache/arrow-rs/pull/6225 | |||
| if (child.output.length == 1 && child.output.head.dataType.isInstanceOf[StructType]) { | |||
There was a problem hiding this comment.
As we add support for other types, do we need to update this to make it recursive so that we check for Map or Array containing struct?
There was a problem hiding this comment.
Let me add more data types here according to arrow-rs.
This was referenced Aug 13, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
(cherry picked from commit 071c780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #807.
Rationale for this change
What changes are included in this PR?
How are these changes tested?