Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add Comet logo files into exclude list #726

Merged
merged 1 commit into from
Jul 26, 2024
Merged

build: Add Comet logo files into exclude list #726

merged 1 commit into from
Jul 26, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 25, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

CI fails to build because newly added logo files fail license check.

[INFO] --- apache-rat:0.16:check (default) @ comet-parent-spark3.4_2.12 ---
[INFO] Rat check: Summary over all files. Unapproved: 7, unknown: 7, generated: 1, approved: 169 licenses.
Warning:  Files with unapproved licenses:
  docs/source/_static/images/logo_original.svg
  docs/source/_static/images/logo_white.svg
  docs/source/_static/images/white.svg
  docs/source/_static/images/dark.svg
  docs/source/_static/images/DataFusionComet-Logo-Dark.svg
  docs/source/_static/images/logo_dark.svg
  docs/source/_static/images/DataFusionComet-Logo-Light.svg

What changes are included in this PR?

How are these changes tested?

andygrove
andygrove approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the original PR that moved the files didn't trigger the rat checks. I'll look into this soon.

@viirya viirya merged commit 8cd6f5b into apache:main Jul 26, 2024
75 checks passed
@viirya
Copy link
Member Author

viirya commented Jul 26, 2024

Thanks @huaxingao @andygrove

@viirya viirya deleted the add_logos_exclude branch July 26, 2024 03:53
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
@viirya @huaxingao
build: Add Comet logo files into exclude list (apache#726)
03d0ad4 
(cherry picked from commit 8cd6f5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaxingao huaxingao huaxingao approved these changes

@andygrove andygrove andygrove approved these changes

@kazuyukitanimura kazuyukitanimura Awaiting requested review from kazuyukitanimura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viirya @andygrove @huaxingao