feat: Support Emit::First for SumDecimalGroupsAccumulator #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #46.
Rationale for this change
If the upstream operator of
HashAggregate
is sorted,HashAggregate
will try to emit first groups if possible. Our customSumDecimalGroupsAccumulator
doesn't supportEmit::First
. So ifSort
is followed byHashAggregate
and there is sum of decimal, the query will fail with:What changes are included in this PR?
How are these changes tested?