feat: Add support for RLike #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
May 24, 2024
Comment on lines
-1097
to
-1105
| // TODO waiting for arrow-rs update | ||
| // case RLike(left, right) => |
There was a problem hiding this comment.
I forgot the details. I remember this was added by someone at the early development. Not sure if we have anything update in arrow-rs for it.
There was a problem hiding this comment.
I did look at arrow-rs and there is support there but it seems to have more logic than we need (including some postgres compatibility).
|
Could I get more feedback on this PR @parthchandra @kazuyukitanimura @huaxingao |
| } else { | ||
| // this should be unreachable because Spark will evaluate regex expressions against | ||
| // literal strings as part of query planning | ||
| Err(CometError::Internal("Only columnar inputs are supported".to_string()).into()) |
There was a problem hiding this comment.
Is it possible to encounter dictionary type?
There was a problem hiding this comment.
Good point. Yes, it probably is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Regular expression support is usually important in ETL jobs, so we should start adding support.
What changes are included in this PR?
Add support for RLike.
How are these changes tested?
New test.