Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: re-enable upload-test-reports for macos-13 runner #1335

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

viirya
Copy link
Member

@viirya viirya commented Jan 24, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

The feature upload-test-reports for macos-13 runner was disabled (#933) previously due to codecov/codecov-action#1549. Trying to re-enable it with upgrading to v5.

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.09%. Comparing base (f09f8af) to head (3c169eb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1335       +/-   ##
=============================================
- Coverage     56.12%   39.09%   -17.04%     
- Complexity      976     2065     +1089     
=============================================
  Files           119      260      +141     
  Lines         11743    60237    +48494     
  Branches       2251    12817    +10566     
=============================================
+ Hits           6591    23548    +16957     
- Misses         4012    32205    +28193     
- Partials       1140     4484     +3344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -197,7 +197,7 @@ jobs:
test-target: [java]
spark-version: ['4.0']
fail-fast: false
if: github.event_name == 'push'
# if: github.event_name == 'push'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily enabling macos-13 runner for pr

@viirya
Copy link
Member Author

viirya commented Jan 25, 2025

Looks like codecov-action v5 works:

https://github.com/apache/datafusion-comet/actions/runs/12958539721/job/36149179797?pr=1335

==> Running upload-coverage
      ./codecov upload-coverage --git-service github --sha 0d16fe5be8211f5f862053d547cc5f1bbcdcfbee --branch viirya:use_codecov_v5 --gcov-executable gcov
info - 2025-01-25 00:08:00,846 -- ci service found: github-actions
warning - 2025-01-25 00:08:00,883 -- No config file could be found. Ignoring config.
warning - 2025-01-25 00:08:00,924 -- No swift data found.
warning - 2025-01-25 00:08:01,204 -- No gcov data found.
warning - 2025-01-25 00:08:01,205 -- coverage.py is not installed or can't be found.
info - 2025-01-25 00:08:01,627 -- Found 3 coverage files to report
info - 2025-01-25 00:08:01,627 -- > /Users/runner/work/datafusion-comet/datafusion-comet/common/target/site/jacoco/jacoco.xml
info - 2025-01-25 00:08:01,627 -- > /Users/runner/work/datafusion-comet/datafusion-comet/spark/target/site/jacoco/jacoco.xml
info - 2025-01-25 00:08:01,627 -- > /Users/runner/work/datafusion-comet/datafusion-comet/docs/spark_builtin_expr_coverage.txt
info - 2025-01-25 00:08:02,138 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/apache/datafusion-comet/commit/0d16fe5be8211f5f862053d547cc5f1bbcdcfbee
info - 2025-01-25 00:08:02,545 -- Process Upload complete

@viirya viirya merged commit 59f172c into apache:main Jan 25, 2025
74 checks passed
@viirya
Copy link
Member Author

viirya commented Jan 25, 2025

Thanks @kazuyukitanimura

@viirya viirya deleted the use_codecov_v5 branch January 25, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants