fix

apache · Jan 23, 2025 · 8c5724d · 8c5724d
1 parent 958476b
commit 8c5724d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/native/core/src/execution/metrics/utils.rs b/native/core/src/execution/metrics/utils.rs
@@ -34,7 +34,7 @@ pub fn update_comet_metric(
 ) -> Result<(), CometError> {
     unsafe {
         let native_metric = to_native_metric_node(spark_plan);
-        let jbytes = env.byte_array_from_slice(&*native_metric?.encode_to_vec())?;
+        let jbytes = env.byte_array_from_slice(&native_metric?.encode_to_vec())?;
         jni_call!(env, comet_metric_node(metric_node).set_all_from_bytes(&jbytes) -> ())?;
     }
     Ok(())

diff --git a/native/core/src/jvm_bridge/mod.rs b/native/core/src/jvm_bridge/mod.rs
@@ -46,13 +46,6 @@ macro_rules! jvalues {
     }}
 }
 
-/// Macro for create a new JNI string.
-macro_rules! jni_new_string {
-    ($env:expr, $value:expr) => {{
-        $crate::jvm_bridge::jni_map_error!($env, $env.new_string($value))
-    }};
-}
-
 /// Macro for calling a JNI method.
 /// The syntax is:
 /// jni_call!(env, comet_metric_node(metric_node).add(jname, value) -> ())?;
@@ -173,7 +166,6 @@ macro_rules! jni_new_global_ref {
 pub(crate) use jni_call;
 pub(crate) use jni_map_error;
 pub(crate) use jni_new_global_ref;
-pub(crate) use jni_new_string;
 pub(crate) use jni_static_call;
 pub(crate) use jvalues;